Allow adding translations for nested fields #6180
Merged
+25
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cr7pt0gr4ph7
added a commit
to cr7pt0gr4ph7/developers.home-assistant
that referenced
this pull request
Sep 10, 2025
Merged
7 tasks
mdegat01
approved these changes
Sep 15, 2025
Contributor
mdegat01
left a comment
mdegat01
left a comment
There was a problem hiding this comment.
Thanks to vol.Self this is really simple and clean, I like it. LGTM 👍
| { | ||
| vol.Required(ATTR_NAME): str, | ||
| vol.Optional(ATTR_DESCRIPTON): vol.Maybe(str), | ||
| vol.Optional(ATTR_FIELDS): {str: vol.Self}, |
Contributor
There was a problem hiding this comment.
This is quite nice. I honestly didn't realize vol.Self was an option for a making a recursive schema
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Allow adding translations for nested fields to support home-assistant/frontend#26997.
This PR is required because Supervisor filters the translation data based on
SCHEMA_TRANSLATION_CONFIGURATIONdefined here, and removes unknown keys.Type of change
Additional information
This PR fixes or closes issue: fixes #Not applicable.This PR is related to issue:Not applicableLink to cli pull request:Not necessary, translation data is simply passed through by the CLI.Link to client library pull request:Not necessary, translation data is already exposed astranslations: dict[str, any]by the client library.Checklist
ruff format supervisor tests)If API endpoints or add-on configuration are added/changed:
CLI updated (if necessary)Not necessary, translation data is simply passed through by the CLI.Client library updated (if necessary)Not necessary, translation data is already exposed astranslations: dict[str, any]by the client library.